impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4822: Implement dynamic log level changes
Date Sat, 04 Feb 2017 01:43:51 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-4822: Implement dynamic log level changes
......................................................................


Patch Set 6:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/5792/6/be/src/util/logging-support.cc
File be/src/util/logging-support.cc:

Line 83: static const string log_inputs[] = {"get_java_log", "set_java_log", "reset_java_log",
Sorry, I didn't realize the log_inputs and the display_members were different strings, it
was easier to read the way it was before.


http://gerrit.cloudera.org:8080/#/c/5792/6/tests/webserver/test_web_pages.py
File tests/webserver/test_web_pages.py:

Line 43:     """ Helper method that polls a given url and asserts the return code is ok and
nit: remove space before "Helper"


Line 48:   def test_log_level_callback(self):
test_log_level


Line 50:     malformed inputs"""
Does not test that the log level modifications are actually in effect.


Line 59:     # Set the log level of a class to TRACE anc confirm the setting is in place
typo: and


Line 67:     self.get_and_check_status(get_loglevel_url, "TRACE")
also check a different class and make sure it's still at DEBUG


Line 75:     self.get_and_check_status(get_loglevel_url, "DEBUG")
also add tests for malformed inputs, e.g., a class that does not exist, empty strings, garbage
log levels, etc.

same for the glog tests

there are some tests below, but I think some cases are missing


-- 
To view, visit http://gerrit.cloudera.org:8080/5792
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I588418e9bcb0b66d33138baf96207a5a35bfbd63
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message