impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning
Date Sat, 04 Feb 2017 00:57:18 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning
......................................................................


Patch Set 4:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/5828/4/be/src/exec/hdfs-scan-node-base.cc
File be/src/exec/hdfs-scan-node-base.cc:

Line 63: // TODO: Remove this flag.
> ... in a compatibility-breaking release.
Done


http://gerrit.cloudera.org:8080/#/c/5828/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

Line 125:   // Counters that track the number of objects mapping to an unknown disk ID. Here,
we use
> How about:
Sounds simpler. Done


Line 129:   private int numFilesNoDiskIds_ = 0;
> remove blank lines (helps wit visual clustering)
Done


Line 355:                 LOG.trace("Hdfs block missing disk ID information: " + block.toString());
> I don't think this prints the full file path right? I think printing the fi
Done


http://gerrit.cloudera.org:8080/#/c/5828/4/fe/src/main/java/org/apache/impala/planner/Planner.java
File fe/src/main/java/org/apache/impala/planner/Planner.java:

Line 313:           "disk Id information.\n" + Joiner.on(", ").join(tableNames) + "\n");
> disk id
Done


http://gerrit.cloudera.org:8080/#/c/5828/4/fe/src/main/java/org/apache/impala/service/Frontend.java
File fe/src/main/java/org/apache/impala/service/Frontend.java:

Line 953:         queryCtx.addToTables_missing_stats(
> The old code with TreeSet was removing duplicate table names, are you still
Ouch, I didn't realize that logic was for removing duplicates. Putting it back. Nice catch.


-- 
To view, visit http://gerrit.cloudera.org:8080/5828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message