impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle
Date Sat, 04 Feb 2017 00:45:40 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-3785: Record query handle for invalid handle
......................................................................


Patch Set 5:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5748/4/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

PS4, Line 193: PrintId(q
> how about PrintId(query_id) for consistency with the other cases? this path
Done


PS4, Line 253: PrintId(q
> same
Done


http://gerrit.cloudera.org:8080/#/c/5748/5/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

PS5, Line 234: 76543210
> the point of using hex format was to make it trivially easy to see that the
It's actually non-trivial anyway because of the way the endian-ness comes out when converting
from a "string" to a hex printed handle.  This was the best way I could find to try to make
that clear.


-- 
To view, visit http://gerrit.cloudera.org:8080/5748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message