impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
Date Sat, 04 Feb 2017 00:13:23 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-1430,IMPALA-4878,IMPALA-4879: codegen native UDAs
......................................................................


Patch Set 15: Code-Review+2

(4 comments)

Looks good to me but see if Marcel wants to take another pass. Also Michael may want to look
again since it includes the UDA arg type fixes.

http://gerrit.cloudera.org:8080/#/c/5161/15/be/src/codegen/llvm-codegen.cc
File be/src/codegen/llvm-codegen.cc:

PS15, Line 822: we are code that
garbled


PS15, Line 888: Clone the function in case
i don't see code below that clones it.  Oh, that happened with the 'true' argument, so reword
to "The function was cloned ..." or something.


Line 907:     }
why don't we need to do the setName() thing in this case too?


http://gerrit.cloudera.org:8080/#/c/5161/15/be/src/codegen/llvm-codegen.h
File be/src/codegen/llvm-codegen.h:

PS15, Line 303: LoadFunction
the names LoadFunction and GetFunction don't really distinguish them that well, so i find
it a little hard when reading the caller code to remember what each one does. i don't have
a great suggestion though...


-- 
To view, visit http://gerrit.cloudera.org:8080/5161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1708eaa96eb76fb9bec5eeabf209f81c88eec2f
Gerrit-PatchSet: 15
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message