impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Russell (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Release note updates for Impala 2.8
Date Sat, 04 Feb 2017 00:05:15 GMT
John Russell has posted comments on this change.

Change subject: Release note updates for Impala 2.8
......................................................................


Patch Set 7:

(10 comments)

Addressed all comments. Dealt with some gerrit glitches (had to squash 2 commits that appeared
to both have the same change ID, one of which had gone into the wrong private branch.)

http://gerrit.cloudera.org:8080/#/c/5668/7/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:

PS7, Line 3297: CDH
> Please do not add new CDH references.
Not adding, this one was already here AFAIK.


http://gerrit.cloudera.org:8080/#/c/5668/6/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

Line 71:             such as <codeph>COMPRESSION</codeph>, <codeph>DEFAULT</codeph>,
and <codeph>ENCODING</codeph>, that
> They are usually done within seconds of each other.
I am occasionally held up for some time resolving a merge conflict or otherwise dealing with
gerrit glitches.


http://gerrit.cloudera.org:8080/#/c/5668/7/docs/topics/impala_incompatible_changes.xml
File docs/topics/impala_incompatible_changes.xml:

Line 63:           <p rev="IMPALA-4372">
> You can remove this. It was only a temporary bug in 2.8. We never shipped a
OK. I had an item mentioning the uppercasing under 2.7. That might have been an assumption
on my part because of the timing of when this came to light. I'll remove it under 2.7 as well.


http://gerrit.cloudera.org:8080/#/c/5668/3/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

PS3, Line 53: / CDH 5.10.x
> I do not see a response to his yet.
Done. I am doing a bunch of replacements with substitution variables in these titles, although
not 100% of the titles in this file. Back in the Impala 1.3 / 1.2 days, there was some discontinuity
around the release numbering (e.g. new features going out in .1 maintenance releases) and
I'll leave that cleanup for a subsequent CR.


PS3, Line 53: / CDH 5.10.x
> Please remove.
Done


Line 84:                 The <codeph>MT_DOP</codeph> query option enables
> The line breaks here are sometimes around 80 characters, and sometimes over
Holding off on making any big changes to line length in individual CRs, saving that for a
global change later.


PS3, Line 100: IMPALA-2522
> This should be IMPALA-2521.  IMPALA-2522 is an Epic that covers much more t
Done


http://gerrit.cloudera.org:8080/#/c/5668/7/docs/topics/impala_new_features.xml
File docs/topics/impala_new_features.xml:

Line 65:               <p rev="IMPALA-4572">
> We should definitely also highlight IMPALA-1430 which fixes the slow COMPUT
Done. I'll do some follow-on work to link to the specific JIRAs rather than just summarizing
each improvement. (I'll probably save that for a follow-on CR.)


Line 130:                 format <codeph>TIMESTAMP</codeph> values, such as the
result
> A naked now() function is a particularly bad example, because now() is alre
Done


PS7, Line 724:  
> New spaces at end of lines
Done. Puzzling because I'm avoiding reformatting existing lines. Trailing spaces are usually
removed by my pre-commit hook but I haven't tested that hook with the ASF repo.


-- 
To view, visit http://gerrit.cloudera.org:8080/5668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c47f422e509cec6d3eb8aaa82294b584f393aed
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Ambreen Kazi <ambreen.kazi@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Greg Rahn <grahn@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Silvius Rus <srus@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message