impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zach Amsden (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4810: Add DECIMAL V2 query option
Date Fri, 03 Feb 2017 20:13:37 GMT
Zach Amsden has posted comments on this change.

Change subject: IMPALA-4810: Add DECIMAL_V2 query option
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5889/1/be/src/exprs/expr.cc
File be/src/exprs/expr.cc:

PS1, Line 620:     case QUERY_OPT_DECIMAL_V2:
             :       DCHECK(false);
             :       return false;
> May want to hold this off to the next change.
Done


http://gerrit.cloudera.org:8080/#/c/5889/1/be/src/exprs/expr.h
File be/src/exprs/expr.h:

PS1, Line 281: QUERY_OPT_DECIMAL_V2,
> May want to hold this off for the next change.
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf25fe5c1766c86ebfe196d49f646e81e50a24e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Michael Ho
Gerrit-Reviewer: Michael Ho <kwho@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message