impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded
Date Fri, 03 Feb 2017 18:02:31 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4839: Remote Kudu tests failing because loopback is hard-coded
......................................................................


Patch Set 4:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5877/4//COMMIT_MSG
Commit Message:

PS4, Line 10: ovderride
spelling


PS4, Line 12: :
s


http://gerrit.cloudera.org:8080/#/c/5877/4/bin/start-impala-cluster.py
File bin/start-impala-cluster.py:

PS4, Line 31: KUDU_MASTER
I think it'd be good to be consistent with the gflag naming, so calling this env var KUDU_MASTER_HOSTS
as well.


-- 
To view, visit http://gerrit.cloudera.org:8080/5877
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9df71480a165f4ce21ae3edab6ce7227fbf76f77
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message