impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Salmon (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4675 Lowercase parquet column names prior to matching
Date Fri, 03 Feb 2017 05:03:30 GMT
Nathan Salmon has uploaded a new patch set (#2).

Change subject: IMPALA-4675 Lowercase parquet column names prior to matching
......................................................................

IMPALA-4675 Lowercase parquet column names prior to matching

With the introduction of the query option
PARQUET_FALLBACK_SCHEMA_RESOLUTION in IMPALA-2835, it became
possible to map table columns to parquet file fields by name.

However, while parquet column names are case sensitive, Impala's
are not.  Impala's case insensitivity is implemented via
consistent use of lowercasing.

This bug presents itself when lowercased column names are compared
with mixed or uppercase columns in parquet.  This is corrected
by simply lowercasing parquet column names prior to comparison.

Change-Id: I87395f84ba29b4c3d8e41be1ea4e89e500b8a9f4
---
M be/src/exec/parquet-metadata-utils.cc
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/91/5891/2
-- 
To view, visit http://gerrit.cloudera.org:8080/5891
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87395f84ba29b4c3d8e41be1ea4e89e500b8a9f4
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Nathan Salmon <nathan.gsalmon@gmail.com>

Mime
View raw message