impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Impala Public Jenkins (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs
Date Fri, 03 Feb 2017 03:40:07 GMT
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs
......................................................................


IMPALA-4868: Fix flaky TestRequestPoolService.testUpdatingConfigs

Occasionally due to timing, testUpdatingConfigs() fails in
jenkins jobs. This can be reproduced by manually changing
the sleep times in the test. The fix is to attempt checking
the results several times, sleeping briefly in between
attempts.

Testing: Manually changed the sleep times to simulate
failure and success cases.

Change-Id: Id94b59039363368d21ebb01cec18ae82d1390546
Reviewed-on: http://gerrit.cloudera.org:8080/5876
Reviewed-by: Tim Armstrong <tarmstrong@cloudera.com>
Tested-by: Impala Public Jenkins
---
M fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java
1 file changed, 17 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Tim Armstrong: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/5876
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id94b59039363368d21ebb01cec18ae82d1390546
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>

Mime
View raw message