impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bharath Vissapragada (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning
Date Thu, 02 Feb 2017 22:52:31 GMT
Bharath Vissapragada has posted comments on this change.

Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning
......................................................................


Patch Set 3:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5828/3/be/src/exec/hdfs-scan-node-base.cc
File be/src/exec/hdfs-scan-node-base.cc:

Line 62
> Sorry for the confusion.
Ah, thanks for clarifying. Makes sense now. I thought gflags would gracefully handle that
situation and ignore any such un-declared flags. I'll make this change.


http://gerrit.cloudera.org:8080/#/c/5828/3/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java
File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java:

Line 343:             if (block.getDiskId(i) == -1) ++numScanRangesNoDiskIds_;
> scan ranges is a pretty low granularity, can you also roll this up to the f
Done


Line 589:       if (numScanRangesNoDiskIds_ > 0) {
> let's only add this for >= EXTENDED
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message