impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] CDH-48291: Fix flaky test TestRequestPoolService
Date Thu, 02 Feb 2017 21:35:18 GMT
Matthew Jacobs has posted comments on this change.

Change subject: CDH-48291: Fix flaky test TestRequestPoolService
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5507/1/fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java
File fe/src/test/java/org/apache/impala/util/TestRequestPoolService.java:

PS1, Line 204:     Thread.sleep(10000L + CHECK_INTERVAL_MS +
             :         AllocationFileLoaderService.ALLOC_RELOAD_WAIT_MS);
> Sorry not following. This seems to be the only test affected by the 10+sec 
I implemented it this way: 
https://gerrit.cloudera.org/#/c/5876/

Seems like it was hit again so I just went ahead and did what I was talking about.


-- 
To view, visit http://gerrit.cloudera.org:8080/5507
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I71a036d5b1227508e2175808d7e92837ae247d99
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogiannis@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message