impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-1427: Improvements to "Unknown disk-ID" warning
Date Thu, 02 Feb 2017 21:19:18 GMT
Alex Behm has posted comments on this change.

Change subject: IMPALA-1427: Improvements to "Unknown disk-ID" warning
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5828/3/be/src/exec/hdfs-scan-node-base.cc
File be/src/exec/hdfs-scan-node-base.cc:

Line 62
> Just want to confirm before I make changes, do you mean we should retain it
Sorry for the confusion.

What I mean is that we should preserve this option exactly as is because if somebody has that
option set, then that cluster won't start anymore after this change. Clusters configured that
way should continue to start. We can remove the option during a compatibility-breaking release.

You should change the textual description of this option to clearly indicate that it is deprecated,
something like:

DEFINE_bool(suppress_unknown_disk_id_warnings, false,
    "Deprecated");

You can grep for "Deprecated" and see how we deal with this elsewhere.


-- 
To view, visit http://gerrit.cloudera.org:8080/5828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message