impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Robinson (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC
Date Thu, 02 Feb 2017 19:31:58 GMT
Henry Robinson has posted comments on this change.

Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

Patch Set 7:

(1 comment)
File be/src/statestore/

Line 379:   subscribers_[0]->WaitForFailure(statestore_.get());
> what's done? i was wondering why the line disappeared.
Sorry, moving fast. This was a bug: if the statestore could detect the failure of the beartbeat
before it got around to sending an update, the update would never show up. There's no reason
for this line - I think it was a bug in the Python version of this test but it never got triggered
because I the heartbeat frequency was left at its normal levels. In this test, I decrease
the hb frequency significantly (so the test runs faster!), and that triggered this bug.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dbf12b9ecd71d26d239d31c19b487175194c766
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <>
Gerrit-Reviewer: Dan Hecht <>
Gerrit-Reviewer: David Knupp <>
Gerrit-Reviewer: Henry Robinson <>
Gerrit-Reviewer: Juan Yu <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-Reviewer: Sailesh Mukil <>
Gerrit-Reviewer: Taras Bobrovytsky <>
Gerrit-HasComments: Yes

View raw message