impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe McDonnell (Code Review)" <>
Subject [Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs
Date Thu, 02 Feb 2017 17:37:10 GMT
Joe McDonnell has posted comments on this change.

Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

Patch Set 6:

File fe/src/main/java/org/apache/impala/analysis/

Line 385:     // sum the number of constants with the maximum distinct value for the
> ... sum the number of distinct constants with the maximum NDV for the non-c
File fe/src/test/java/org/apache/impala/analysis/

Line 27:  * Tests computeNumDistinctValues estimates for Exprs
> computeNumDistinctValues()

Line 31:   public void VerifyNdvBasic(String expr, long expectedNdv)
> yeah, i think i messed that up.

Line 44:   public void VerifyNdv(String stmtStr, long expectedNdv)
> can we make this VerifyNdvStmt() or something so that we can use VerifyNdv(

Line 93:     // functional.tinytable (tiny) does not
> move this into the function comment of VerifyNdvTwoTable()

Line 96:     VerifyNdvTwoTable("case when = 1 then 'yes' " + 
> remove whitespace
Done, also fixed emacs to highlight these

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I21dbdaad8452b7e58c477612b47847dccd9d98d2
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <>
Gerrit-Reviewer: Alex Behm <>
Gerrit-Reviewer: Joe McDonnell <>
Gerrit-Reviewer: Marcel Kornacker <>
Gerrit-HasComments: Yes

View raw message