impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4359: qgen: add UPSERT support
Date Thu, 02 Feb 2017 00:29:01 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4359: qgen: add UPSERT support
......................................................................


Patch Set 2:

(3 comments)

Thanks for the review, Taras. Please see patch set 2.

http://gerrit.cloudera.org:8080/#/c/5795/1/tests/comparison/model_translator.py
File tests/comparison/model_translator.py:

PS1, Line 534: be
> Why 1 here? Are we expecting there to be several "INSERT" keywords in the q
Done


http://gerrit.cloudera.org:8080/#/c/5795/1/tests/comparison/query.py
File tests/comparison/query.py:

Line 705:   # This enum represents possibilities for different types of INSERTs. A user of
this
> I see that you explained what these mean below, but it's not to perfectly c
Done


PS1, Line 727:  so th
> inserting into a Kudu table
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/5795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6382f6ab22ba29c117e39a5d90592d3637df4b25
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message