impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcel Kornacker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs
Date Thu, 02 Feb 2017 00:02:46 GMT
Marcel Kornacker has posted comments on this change.

Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs
......................................................................


Patch Set 5:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/5768/5/fe/src/test/java/org/apache/impala/analysis/ExprNdvTest.java
File fe/src/test/java/org/apache/impala/analysis/ExprNdvTest.java:

Line 32: 	String stmtStr = "select " + expr + " from functional.alltypes";
remove tabs and trailing spaces


Line 42:   public Expr CalcsNdvOk(String stmtStr, long expectedNdv)
odd/not immediately intuitive name


Line 48:     // Go into the select list and get the expression
superfluous comment (it simply states what's apparent from the next line), remove


Line 51: 
use blank lines judiciously, to separate logically separate pieces of code


Line 54:     return analyzedExpr;
why return anything?


Line 71:     CalcsNdvOkBasic("case when id = 1 then 'yes' when id = 2 then 'maybe' else 'no'
end", 3);
long line (and elsewhere)


-- 
To view, visit http://gerrit.cloudera.org:8080/5768
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21dbdaad8452b7e58c477612b47847dccd9d98d2
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonnell@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <marcel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message