impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthew Jacobs (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4738: STDDEV SAMP should return NULL for single record input
Date Wed, 01 Feb 2017 20:20:04 GMT
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-4738: STDDEV_SAMP should return NULL for single record input
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

please let john know we should doc this change

http://gerrit.cloudera.org:8080/#/c/5800/2/testdata/workloads/functional-query/queries/QueryTest/aggregation.test
File testdata/workloads/functional-query/queries/QueryTest/aggregation.test:

PS2, Line 26: ,
please add a space


PS2, Line 30: 0,0
so all of these match postgres now?


-- 
To view, visit http://gerrit.cloudera.org:8080/5800
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ide8af752cd8a2e554a2cd5a1ec948967a80de1fe
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: anujphadke <aphadke@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj@cloudera.com>
Gerrit-Reviewer: anujphadke <aphadke@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message