Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 8834D200BF6 for ; Tue, 10 Jan 2017 18:37:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 86CFB160B3D; Tue, 10 Jan 2017 17:37:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D089D160B2C for ; Tue, 10 Jan 2017 18:37:04 +0100 (CET) Received: (qmail 62709 invoked by uid 500); 10 Jan 2017 17:37:04 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 62697 invoked by uid 99); 10 Jan 2017 17:37:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jan 2017 17:37:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 9C116180140 for ; Tue, 10 Jan 2017 17:37:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.518 X-Spam-Level: X-Spam-Status: No, score=-4.518 tagged_above=-999 required=6.31 tests=[HTML_MESSAGE=2, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, RP_MATCHES_RCVD=-2.999, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id uPyRECQ1vPX3 for ; Tue, 10 Jan 2017 17:37:02 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id 3BFB25FC81 for ; Tue, 10 Jan 2017 17:37:02 +0000 (UTC) Received: (qmail 62672 invoked by uid 99); 10 Jan 2017 17:37:01 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jan 2017 17:37:01 +0000 Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 53CE41A0314 for ; Tue, 10 Jan 2017 17:37:01 +0000 (UTC) Received: by mail-wm0-f46.google.com with SMTP id a197so135309775wmd.0 for ; Tue, 10 Jan 2017 09:37:01 -0800 (PST) X-Gm-Message-State: AIkVDXLFG4fxAsOUfz5zg3P1qoV6GNHWXnmag0P0miHVTDePDY/bD9QSNNTxBhkjLY82BkMCiMJ24dG0sgi9wvpC X-Received: by 10.223.176.93 with SMTP id g29mr2666354wra.12.1484069820199; Tue, 10 Jan 2017 09:37:00 -0800 (PST) MIME-Version: 1.0 References: <201701101733.v0AHXMr8018340@ip-10-146-233-104.ec2.internal> In-Reply-To: <201701101733.v0AHXMr8018340@ip-10-146-233-104.ec2.internal> From: Henry Robinson Date: Tue, 10 Jan 2017 17:36:49 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Impala-ASF-CR] IMPALA-4751: Remove blank line from raw text template To: Lars Volker , impala-cr@cloudera.com, reviews@impala.incubator.apache.org, tarmstrong@cloudera.com Cc: David Knupp , Jim Apple Content-Type: multipart/alternative; boundary=001a113bef5674a6f30545c0ee8c archived-at: Tue, 10 Jan 2017 17:37:05 -0000 --001a113bef5674a6f30545c0ee8c Content-Type: text/plain; charset=UTF-8 Let's get it in. We can discuss the other issues later. On Tue, Jan 10, 2017 at 9:33 AM Tim Armstrong (Code Review) < gerrit@cloudera.org> wrote: > Tim Armstrong has posted comments on this change. > > > > Change subject: IMPALA-4751: Remove blank line from raw_text template > > ...................................................................... > > > > > > Patch Set 2: Code-Review+1 > > > > -- > > To view, visit http://gerrit.cloudera.org:8080/5664 > > To unsubscribe, visit http://gerrit.cloudera.org:8080/settings > > > > Gerrit-MessageType: comment > > Gerrit-Change-Id: I9b688aa9e2423b0271c8891a983e5b22707d8dbc > > Gerrit-PatchSet: 2 > > Gerrit-Project: Impala-ASF > > Gerrit-Branch: master > > Gerrit-Owner: Lars Volker > > Gerrit-Reviewer: David Knupp > > Gerrit-Reviewer: Henry Robinson > > Gerrit-Reviewer: Impala Public Jenkins > > Gerrit-Reviewer: Jim Apple > > Gerrit-Reviewer: Lars Volker > > Gerrit-Reviewer: Tim Armstrong > > Gerrit-HasComments: No > > --001a113bef5674a6f30545c0ee8c--