Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A2E25200C0D for ; Tue, 31 Jan 2017 20:58:01 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id A190A160B52; Tue, 31 Jan 2017 19:58:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id EA02C160B36 for ; Tue, 31 Jan 2017 20:58:00 +0100 (CET) Received: (qmail 92227 invoked by uid 500); 31 Jan 2017 19:58:00 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 92199 invoked by uid 99); 31 Jan 2017 19:57:59 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Jan 2017 19:57:59 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 8D77AC0096 for ; Tue, 31 Jan 2017 19:57:59 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id fgPrrwMsuHxK for ; Tue, 31 Jan 2017 19:57:58 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8DE175FBC3 for ; Tue, 31 Jan 2017 19:57:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0VJvlcT025945; Tue, 31 Jan 2017 19:57:47 GMT Message-Id: <201701311957.v0VJvlcT025945@ip-10-146-233-104.ec2.internal> Date: Tue, 31 Jan 2017 19:57:47 +0000 From: "Michael Ho (Code Review)" To: Zach Amsden , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Alex Behm , Tim Armstrong Reply-To: kwho@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4729=3A_Implement_REPLACE=28=29=0A?= X-Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6a75ab2a61a68404791a2473507529535baf564d In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 31 Jan 2017 19:58:01 -0000 Michael Ho has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/5/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: PS5, Line 266: UNLIKELY(check_space)) > Well it was unlikely when I over-allocated the space. Now it is still prob Yes. I usually leave UNLIKELY() to error cases only. The general consensus (from my past experience) is that we use LIKELY/UNLIKELY on critical paths only. -- To view, visit http://gerrit.cloudera.org:8080/5776 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1780a7d8fee6d0db9dad148217fb6eb10f773329 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Zach Amsden Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-Reviewer: Zach Amsden Gerrit-HasComments: Yes