Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9579B200C06 for ; Fri, 27 Jan 2017 22:54:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 94188160B5B; Fri, 27 Jan 2017 21:54:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF49C160B40 for ; Fri, 27 Jan 2017 22:54:04 +0100 (CET) Received: (qmail 26539 invoked by uid 500); 27 Jan 2017 21:54:04 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 26528 invoked by uid 99); 27 Jan 2017 21:54:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jan 2017 21:54:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 6C4A1C0F8E for ; Fri, 27 Jan 2017 21:54:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id HMKFb1OYqsX6 for ; Fri, 27 Jan 2017 21:54:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 18F575F30B for ; Fri, 27 Jan 2017 21:54:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0RLrf6m004075; Fri, 27 Jan 2017 21:53:41 GMT Message-Id: <201701272153.v0RLrf6m004075@ip-10-146-233-104.ec2.internal> Date: Fri, 27 Jan 2017 21:53:41 +0000 From: "David Knupp (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Harrison Sheinblatt , Jim Apple , Dimitris Tsirogiannis Reply-To: dknupp@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4482=3A_Use_ALTER_TABLE_/_RECOVER_PARTITIONS_when_loading_tpcds=2Estore_sales=0A?= X-Gerrit-Change-Id: Iaae97d1d44201aeeacacdd39adbae35753512950 X-Gerrit-ChangeURL: X-Gerrit-Commit: 144d2174536377af9eae39f853dbcb545b578b3f In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 27 Jan 2017 21:54:05 -0000 David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales ...................................................................... Patch Set 7: I'm 100% willing to admit that I could be wrong in my understanding of this. In the meantime, I'm going look into seeing if there's a quick fix to be made in generate-schema-statements.py for why {db_name} is not working here. I agree with you that it probably should. -- To view, visit http://gerrit.cloudera.org:8080/5177 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaae97d1d44201aeeacacdd39adbae35753512950 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Dimitris Tsirogiannis Gerrit-Reviewer: Harrison Sheinblatt Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Jim Apple Gerrit-HasComments: No