Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1EEFF200C08 for ; Thu, 26 Jan 2017 19:05:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1D829160B4C; Thu, 26 Jan 2017 18:05:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6691B160B31 for ; Thu, 26 Jan 2017 19:05:04 +0100 (CET) Received: (qmail 76953 invoked by uid 500); 26 Jan 2017 18:05:03 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 76941 invoked by uid 99); 26 Jan 2017 18:05:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 18:05:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id F33D81A0460 for ; Thu, 26 Jan 2017 18:05:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id XeeVr4U6v_Qn for ; Thu, 26 Jan 2017 18:05:00 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id C005D5F4A8 for ; Thu, 26 Jan 2017 18:04:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0QI3qnC003732; Thu, 26 Jan 2017 18:03:52 GMT Message-Id: <201701261803.v0QI3qnC003732@ip-10-146-233-104.ec2.internal> Date: Thu, 26 Jan 2017 18:03:52 +0000 From: "Jim Apple (Code Review)" To: Jim Apple , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht , Marcel Kornacker , Tim Armstrong Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Add_a_build_flag_for_the_undefined_behavior_sanitizer=2C_aka_=22ubsan=22=2E=0A?= X-Gerrit-Change-Id: I88c7234bd7c5eb7404490a0913d90470c10835e7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 76f12d6f5d475e6d7ab03cc4bbd197fa2b8fb048 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 26 Jan 2017 18:05:05 -0000 Jim Apple has posted comments on this change. Change subject: Add a build flag for the undefined behavior sanitizer, aka "ubsan". ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5082/4/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: Line 434: if (mem_tracker_ != nullptr) { > can mem_tracker_ actually be null here? Yes. I don't rebember the backtrace anymore, but I do remember that UBSAN complained that MemLimitExceeded (or any member function) should not be called on a nullptr object. -- To view, visit http://gerrit.cloudera.org:8080/5082 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88c7234bd7c5eb7404490a0913d90470c10835e7 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes