Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3AB04200C08 for ; Thu, 26 Jan 2017 11:07:03 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 39305160B4C; Thu, 26 Jan 2017 10:07:03 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 812B0160B40 for ; Thu, 26 Jan 2017 11:07:02 +0100 (CET) Received: (qmail 74959 invoked by uid 500); 26 Jan 2017 10:07:01 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 74939 invoked by uid 99); 26 Jan 2017 10:07:01 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 26 Jan 2017 10:07:01 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id EE8B118C8CD for ; Thu, 26 Jan 2017 10:07:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id irIp0Ak0FbvR for ; Thu, 26 Jan 2017 10:07:00 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id E94655F644 for ; Thu, 26 Jan 2017 10:06:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0QA6wGL031892; Thu, 26 Jan 2017 10:06:58 GMT Message-Id: <201701261006.v0QA6wGL031892@ip-10-146-233-104.ec2.internal> Date: Thu, 26 Jan 2017 10:06:58 +0000 From: "Jim Apple (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , Dan Hecht Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3202=3A_implement_spill-to-disk_in_new_buffer_pool=0A?= X-Gerrit-Change-Id: I8c6119a4557da853fefa02e17c49d8be0e9fbe01 X-Gerrit-ChangeURL: X-Gerrit-Commit: 83e24160e655eeb20f907cd138ce7dd6151194b1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 26 Jan 2017 10:07:03 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-3202: implement spill-to-disk in new buffer pool ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/5584/17/be/src/runtime/bufferpool/buffer-pool.h File be/src/runtime/bufferpool/buffer-pool.h: Line 306: alignas(CACHE_LINE_SIZE) SpinLock clean_pages_lock_; type 'impala::BufferPool' requires 64 bytes of alignment and the default allocator only guarantees 16 bytes [clang-diagnostic-over-aligned] You can inherit from CacheLineAligned. Since you have defined CACHE_LINE_SIZE in this patch, you could change the constant 64 in aligned-new.h to be CACHE_LINE_SIZE. -- To view, visit http://gerrit.cloudera.org:8080/5584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c6119a4557da853fefa02e17c49d8be0e9fbe01 Gerrit-PatchSet: 17 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes