Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0F97E200C09 for ; Wed, 25 Jan 2017 21:35:36 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0E15C160B4E; Wed, 25 Jan 2017 20:35:36 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5712A160B3D for ; Wed, 25 Jan 2017 21:35:35 +0100 (CET) Received: (qmail 95973 invoked by uid 500); 25 Jan 2017 20:35:34 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 95962 invoked by uid 99); 25 Jan 2017 20:35:34 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 20:35:34 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B5A4D1A0798 for ; Wed, 25 Jan 2017 20:35:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id IwZWO5Hw5-5j for ; Wed, 25 Jan 2017 20:35:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8D7FB5F3BD for ; Wed, 25 Jan 2017 20:35:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0PKZUIh011909; Wed, 25 Jan 2017 20:35:30 GMT Message-Id: <201701252035.v0PKZUIh011909@ip-10-146-233-104.ec2.internal> Date: Wed, 25 Jan 2017 20:35:30 +0000 From: "David Knupp (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple Reply-To: dknupp@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4750=3A_Rename_test_infra_classes_so_they_don=27t_mimic_test_classes=2E=0A?= X-Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 X-Gerrit-ChangeURL: X-Gerrit-Commit: b318974e1a6713113d2ed0ab672f10565a030777 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 25 Jan 2017 20:35:36 -0000 David Knupp has posted comments on this change. Change subject: IMPALA-4750: Rename test infra classes so they don't mimic test classes. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5794/1/tests/experiments/test_targeted_perf.py File tests/experiments/test_targeted_perf.py: PS1, Line 33: TestMatrix > I think it's best to figure out who or what runs this file before committin OK, I'll send email out to the team. FWIW, if you run these tests, they (mostly) don't pass either. Given thir location, failures, and the fact that this file hasn't been touched since 2013, I feel pretty sure this is dead code. -- To view, visit http://gerrit.cloudera.org:8080/5794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06b7bc6fd99fbb637a47ba376bf9830705c1fce1 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: David Knupp Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Jim Apple Gerrit-HasComments: Yes