Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201701250727.v0P7RLKs002679@ip-10-146-233-104.ec2.internal>
Date: Wed, 25 Jan 2017 07:27:21 +0000
From: "David Knupp (Code Review)" <gerrit@cloudera.org>
To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org
CC: Jim Apple <jbapple-impala@apache.org>
Reply-To: dknupp@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D=28asf-site=29_Initial_commit_of_the_blog_section_of_the_Impala_ASF_website=2E=0A?=
In-Reply-To: <gerrit.1484076695000.If5810f04b56c587a5114953cae7e4f484a92be75@gerrit.cloudera.org>
References: <gerrit.1484076695000.If5810f04b56c587a5114953cae7e4f484a92be75@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 25 Jan 2017 07:27:27 -0000

David Knupp has posted comments on this change.

Change subject: Initial commit of the blog section of the Impala ASF website.
......................................................................


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/5667/4/nikola_site_generator/README.md
File nikola_site_generator/README.md:

Line 18: You will need to install a few python packages to work with Nikola. It's up to you whether you
> Can you word wrap at 90 characters like in the Java and C++ source code?
Done


PS4, Line 44: (blog_env) $ pip install -r requirements.txt
> This is the only line I need if I don't wish to use a virtualenv, right?
You'd probably have to sudo it, but yeah.


Line 74: .. slug: my-new-post
> What is a slug?
The slug is the human-readable last portion of the permalink for a post. E.g., if my blog post is titled "Apache Kudu and Apache Impala (Incubating): The Integration Roadmap", I might want to have the slug be something like "kudu-impala-integration-roadmap", making the permalink to the article: http://impala.apache.org/blog/posts/kudu-impala-integration-roadmap/.


PS4, Line 110: ``TEASER_END```
> mismatched number of backticks
Done


PS4, Line 163: browser
> I think I can also just point my browser at the .html files with "file:///.
Apparently so. In my experience, it's usually better to run a simple development server, but maybe that's because I've done more with dynamically generated sites. In this case, it seems not to matter.


-- 
To view, visit http://gerrit.cloudera.org:8080/5667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If5810f04b56c587a5114953cae7e4f484a92be75
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-Owner: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-HasComments: Yes