Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3E0E3200C2A for ; Wed, 25 Jan 2017 02:59:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3B7AF160B3E; Wed, 25 Jan 2017 01:59:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8DBB3160B4B for ; Wed, 25 Jan 2017 02:59:50 +0100 (CET) Received: (qmail 53700 invoked by uid 500); 25 Jan 2017 01:59:49 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 53689 invoked by uid 99); 25 Jan 2017 01:59:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2017 01:59:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 2F1E71A02BD for ; Wed, 25 Jan 2017 01:59:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HvFIO1zbObLc for ; Wed, 25 Jan 2017 01:59:48 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 44FBD5F649 for ; Wed, 25 Jan 2017 01:59:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0P1xldb032623; Wed, 25 Jan 2017 01:59:47 GMT Message-Id: <201701250159.v0P1xldb032623@ip-10-146-233-104.ec2.internal> Date: Wed, 25 Jan 2017 01:59:47 +0000 From: "Tim Armstrong (Code Review)" To: Michael Ho , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4705=2C_IMPALA-4779=2C_IMPALA-4780=3A_Fix_some_Expr_bugs_with_codegen=0A?= X-Gerrit-Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608 X-Gerrit-ChangeURL: X-Gerrit-Commit: 8e6a85c789dedf5f78c3760b9da5cfd53777041c In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 25 Jan 2017 01:59:51 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4705, IMPALA-4779, IMPALA-4780: Fix some Expr bugs with codegen ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5732/4/be/src/exprs/timestamp-functions.h File be/src/exprs/timestamp-functions.h: Line 44: /// with its defined max year. date(max_date_time).year() will give 9999 but testing I missed updating MAX_YEAR to 9999 in my patch 69859bddfb058d742cece7d7c2e3e3f07f29bb6a - this comment about boost being inconsistent no longer applies. I can also do this in a separate patch but it might be easiest just to fix it now. -- To view, visit http://gerrit.cloudera.org:8080/5732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40fdb035a565ae2f9c9fbf4db48a548653ef7608 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes