Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DAF86200C14 for ; Tue, 24 Jan 2017 06:36:16 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D98DD160B53; Tue, 24 Jan 2017 05:36:16 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2F102160B49 for ; Tue, 24 Jan 2017 06:36:16 +0100 (CET) Received: (qmail 46314 invoked by uid 500); 24 Jan 2017 05:36:15 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 46303 invoked by uid 99); 24 Jan 2017 05:36:15 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Jan 2017 05:36:15 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A166CC1333 for ; Tue, 24 Jan 2017 05:36:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id LYhswYXP8hOG for ; Tue, 24 Jan 2017 05:36:13 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id F19D75F23A for ; Tue, 24 Jan 2017 05:36:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0O5a6E7011176; Tue, 24 Jan 2017 05:36:06 GMT Message-Id: <201701240536.v0O5a6E7011176@ip-10-146-233-104.ec2.internal> Date: Tue, 24 Jan 2017 05:36:06 +0000 From: "Juan Yu (Code Review)" To: Henry Robinson , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker , Taras Bobrovytsky , Sailesh Mukil , David Knupp Reply-To: jyu@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4670_/_IMPALA-4672=3A_Add_RpcMgr_and_port_Statestore_services_to_KRPC=0A?= X-Gerrit-Change-Id: I8dbf12b9ecd71d26d239d31c19b487175194c766 X-Gerrit-ChangeURL: X-Gerrit-Commit: a4c26aacdff8c05d7c93154ad141ae0e80249897 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Tue, 24 Jan 2017 05:36:17 -0000 Juan Yu has posted comments on this change. Change subject: IMPALA-4670 / IMPALA-4672: Add RpcMgr and port Statestore services to KRPC ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5720/2/be/src/statestore/statestore.proto File be/src/statestore/statestore.proto: PS2, Line 41: UpdateState I feel 'Topic' is more clear, like UpdateTopic, UpdateTopicRequestPB, UpdateTopicResponsePB -- To view, visit http://gerrit.cloudera.org:8080/5720 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8dbf12b9ecd71d26d239d31c19b487175194c766 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: David Knupp Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Juan Yu Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Taras Bobrovytsky Gerrit-HasComments: Yes