Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 870E7200C01 for ; Thu, 19 Jan 2017 18:30:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 85BF6160B3A; Thu, 19 Jan 2017 17:30:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D0D38160B54 for ; Thu, 19 Jan 2017 18:30:36 +0100 (CET) Received: (qmail 26957 invoked by uid 500); 19 Jan 2017 17:30:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 26943 invoked by uid 99); 19 Jan 2017 17:30:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2017 17:30:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 5F4B31A011E for ; Thu, 19 Jan 2017 17:30:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id iQDfKSS_CAEt for ; Thu, 19 Jan 2017 17:30:32 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 478B15FCD8 for ; Thu, 19 Jan 2017 17:30:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0JHUT40027351; Thu, 19 Jan 2017 17:30:29 GMT Message-Id: <201701191730.v0JHUT40027351@ip-10-146-233-104.ec2.internal> Date: Thu, 19 Jan 2017 17:30:29 +0000 From: "Dan Hecht (Code Review)" To: Alex Behm , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Bharath Vissapragada Reply-To: dhecht@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4789=3A_Fix_slow_metadata_loading_due_to_inconsistent_paths=2E=0A?= X-Gerrit-Change-Id: I8c881b7cb155032b82fba0e29350ca31de388d55 X-Gerrit-ChangeURL: X-Gerrit-Commit: ec13f38c797ec5102ee4dd7f4699dba7b8ceb8ce In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 19 Jan 2017 17:30:37 -0000 Dan Hecht has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5743/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: Line 263 > why don't we just make partDir and dirPath qualified paths before calling F Oh never mind, i didn't read the change description carefully enough. -- To view, visit http://gerrit.cloudera.org:8080/5743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c881b7cb155032b82fba0e29350ca31de388d55 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm Gerrit-Reviewer: Bharath Vissapragada Gerrit-Reviewer: Dan Hecht Gerrit-HasComments: Yes