Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id C44D7200C0F for ; Thu, 19 Jan 2017 03:34:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id C2C0F160B44; Thu, 19 Jan 2017 02:34:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 154BD160B43 for ; Thu, 19 Jan 2017 03:34:44 +0100 (CET) Received: (qmail 14114 invoked by uid 500); 19 Jan 2017 02:34:44 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 14099 invoked by uid 99); 19 Jan 2017 02:34:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jan 2017 02:34:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 729EAC00B6 for ; Thu, 19 Jan 2017 02:34:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WJAzhJ0RAVYP for ; Thu, 19 Jan 2017 02:34:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 4CCE25F1EF for ; Thu, 19 Jan 2017 02:34:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0J2YelH018491; Thu, 19 Jan 2017 02:34:40 GMT Message-Id: <201701190234.v0J2YelH018491@ip-10-146-233-104.ec2.internal> Date: Thu, 19 Jan 2017 02:34:40 +0000 From: "Impala Public Jenkins (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4678=3A_move_query_MemTracker_into_QueryState=0A?= X-Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 85edc15fefe9ab9b2883b9c9f7451efc7e26ff94 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 19 Jan 2017 02:34:46 -0000 Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4678: move query MemTracker into QueryState ...................................................................... IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query execution is now owned directly by QueryState, which greatly simplifies the lifecycle of the MemTracker. This required various other changes and enabled some simplifications. * The coordinator's QueryState is constructed earlier before fragments are sent out, since we need a MemTracker at that point. * The global query MemTracker map can be removed. * The static request pool mem tracker is moved into into ExecEnv. * Temporary query MemTrackers used to evaluate expressions during planning do not need to be registered globally and are owned directly by the RuntimeState. * Various cleanup logic is moved around to reflect the other changes. Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Reviewed-on: http://gerrit.cloudera.org:8080/5630 Reviewed-by: Tim Armstrong Tested-by: Impala Public Jenkins --- M be/src/exec/hash-table-test.cc M be/src/exprs/expr-test.cc M be/src/runtime/buffered-block-mgr-test.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/runtime/data-stream-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h M be/src/runtime/plan-fragment-executor.cc M be/src/runtime/query-exec-mgr.cc M be/src/runtime/query-exec-mgr.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/runtime/test-env.cc M be/src/runtime/test-env.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/scheduling/admission-controller.cc M be/src/service/fe-support.cc M be/src/service/impala-http-handler.cc M be/src/service/query-exec-state.cc 25 files changed, 372 insertions(+), 353 deletions(-) Approvals: Impala Public Jenkins: Verified Tim Armstrong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Gerrit-PatchSet: 12 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong