Return-Path: <reviews-return-6882-archive-asf-public=cust-asf.ponee.io@impala.incubator.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 3E546200C00
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 18 Jan 2017 23:51:10 +0100 (CET)
Received: by cust-asf.ponee.io (Postfix)
	id 3CCAE160B43; Wed, 18 Jan 2017 22:51:10 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 83400160B22
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 18 Jan 2017 23:51:09 +0100 (CET)
Received: (qmail 23107 invoked by uid 500); 18 Jan 2017 22:51:08 -0000
Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@impala.incubator.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@impala.incubator.apache.org>
List-Post: <mailto:reviews@impala.incubator.apache.org>
List-Id: <reviews.impala.incubator.apache.org>
Delivered-To: mailing list reviews@impala.incubator.apache.org
Received: (qmail 23096 invoked by uid 99); 18 Jan 2017 22:51:08 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 22:51:08 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1DD8018066C
	for <reviews@impala.apache.org>; Wed, 18 Jan 2017 22:51:08 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 0.363
X-Spam-Level: 
X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31
	tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001]
	autolearn=disabled
Received: from mx1-lw-us.apache.org ([10.40.0.8])
	by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024)
	with ESMTP id r-o8iCeggUXV for <reviews@impala.apache.org>;
	Wed, 18 Jan 2017 22:51:06 +0000 (UTC)
Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251])
	by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 03C685FDC3
	for <reviews@impala.incubator.apache.org>; Wed, 18 Jan 2017 22:51:06 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0IMp3jN011396;
	Wed, 18 Jan 2017 22:51:03 GMT
Message-Id: <201701182251.v0IMp3jN011396@ip-10-146-233-104.ec2.internal>
Date: Wed, 18 Jan 2017 22:51:03 +0000
From: "Tim Armstrong (Code Review)" <gerrit@cloudera.org>
To: John Russell <jrussell@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: Alex Behm <alex.behm@cloudera.com>,
        Mostafa Mokhtar <mmokhtar@cloudera.com>
Reply-To: tarmstrong@cloudera.com
X-Gerrit-MessageType: comment
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Add_doc_for_MT_DOP_query_option=2E=0A?=
X-Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
X-Gerrit-ChangeURL: <http://gerrit.cloudera.org:8080/5652>
X-Gerrit-Commit: 170934610e0b56dcfb647086f5df39d28fbe0729
In-Reply-To: <gerrit.1484008907000.Ife2786532b425af6d230074f1c0b5c7dcb2b8a92@gerrit.cloudera.org>
References: <gerrit.1484008907000.Ife2786532b425af6d230074f1c0b5c7dcb2b8a92@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 18 Jan 2017 22:51:10 -0000

Tim Armstrong has posted comments on this change.

Change subject: Add doc for MT_DOP query option.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xml
File docs/topics/impala_mt_dop.xml:

Line 43:     </p>
I think it would make sense to document (for now) that many queries don't support mt_dop, so that users aren't surprised to get an error after setting it. E.g. 

[localhost:21000] > set mt_dop=1;
MT_DOP set to 1
[localhost:21000] > select * from functional.alltypes a1 inner join functional.alltypes a2 on a1.id = a2.id limit 4;
Query: select * from functional.alltypes a1 inner join functional.alltypes a2 on a1.id = a2.id limit 4
Query submitted at: 2017-01-18 14:49:46 (Coordinator: http://tarmstrong-box:25000)
ERROR: NotImplementedException: MT_DOP not supported for plans with base table joins or table sinks.


-- 
To view, visit http://gerrit.cloudera.org:8080/5652
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife2786532b425af6d230074f1c0b5c7dcb2b8a92
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mmokhtar@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstrong@cloudera.com>
Gerrit-HasComments: Yes