Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4F2F9200C00 for ; Wed, 18 Jan 2017 21:03:26 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 4DF5C160B43; Wed, 18 Jan 2017 20:03:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 92BB1160B22 for ; Wed, 18 Jan 2017 21:03:25 +0100 (CET) Received: (qmail 80284 invoked by uid 500); 18 Jan 2017 20:03:24 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 80273 invoked by uid 99); 18 Jan 2017 20:03:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jan 2017 20:03:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 1345EC0270 for ; Wed, 18 Jan 2017 20:03:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id BW1NZwx3e6di for ; Wed, 18 Jan 2017 20:03:21 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id AF4005F282 for ; Wed, 18 Jan 2017 20:03:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0IK38vN004119; Wed, 18 Jan 2017 20:03:08 GMT Message-Id: <201701182003.v0IK38vN004119@ip-10-146-233-104.ec2.internal> Date: Wed, 18 Jan 2017 20:03:08 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4678=3A_move_query_MemTracker_into_QueryState=0A?= X-Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 X-Gerrit-ChangeURL: X-Gerrit-Commit: 06e5c53e25d373f6bdbad81f73e3abc44a3b0692 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 18 Jan 2017 20:03:26 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-4678: move query MemTracker into QueryState ...................................................................... Patch Set 4: (1 comment) I didn't mean to push out PS8 - PS9 reverts the PS8 change. http://gerrit.cloudera.org:8080/#/c/5630/4/be/src/runtime/query-state.h File be/src/runtime/query-state.h: Line 135: std::unique_ptr query_mem_tracker_; > MemTracker query_mem_tracker_ I did it this way to let us forward declare MemTracker and avoid pulling the MemTracker header in everywhere (since query-state.h will be included a lot of places). Also we need to pass arguments into the MemTracker constructor, which would force a fair bit of restructuring (could no longer use CreateQueryMemTracker(), etc). -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Marcel Kornacker Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes