Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7B398200C06 for ; Fri, 13 Jan 2017 00:11:51 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 79CBF160B40; Thu, 12 Jan 2017 23:11:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C3A13160B4C for ; Fri, 13 Jan 2017 00:11:50 +0100 (CET) Received: (qmail 29026 invoked by uid 500); 12 Jan 2017 23:11:50 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 29015 invoked by uid 99); 12 Jan 2017 23:11:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jan 2017 23:11:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3B761C023D for ; Thu, 12 Jan 2017 23:11:49 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ffDvp54iV1I6 for ; Thu, 12 Jan 2017 23:11:48 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 7E1475F4AE for ; Thu, 12 Jan 2017 23:11:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0CNBe0u013711; Thu, 12 Jan 2017 23:11:40 GMT Message-Id: <201701122311.v0CNBe0u013711@ip-10-146-233-104.ec2.internal> Date: Thu, 12 Jan 2017 23:11:40 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4678=3A_move_query_MemTracker_into_QueryState=0A?= X-Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 X-Gerrit-ChangeURL: X-Gerrit-Commit: d2488c3d33862fee4bfbb833ef71801d960bc0e0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 12 Jan 2017 23:11:51 -0000 Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-4678: move query MemTracker into QueryState ...................................................................... IMPALA-4678: move query MemTracker into QueryState The query MemTracker for query execution is now owned directly by QueryState, which greatly simplifies the lifecycle of the MemTracker. This required various other changes and enabled some simplifications: * The coordinator's QueryState is constructed earlier before fragments are sent out, since we need a MemTracker at that point. * The global query MemTracker map can be removed. * The static request pool mem tracker is moved into into ExecEnv. * Temporary query MemTrackers used to evaluate expressions during planning do not need to be registered globally and are owned directly by the RuntimeState. * Various cleanup logic is moved around to reflect the other changes. Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 --- M be/src/exec/hash-table-test.cc M be/src/exprs/expr-test.cc M be/src/runtime/buffered-block-mgr-test.cc M be/src/runtime/buffered-tuple-stream-test.cc M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h M be/src/runtime/data-stream-test.cc M be/src/runtime/exec-env.cc M be/src/runtime/exec-env.h M be/src/runtime/mem-tracker.cc M be/src/runtime/mem-tracker.h M be/src/runtime/plan-fragment-executor.cc M be/src/runtime/query-exec-mgr.cc M be/src/runtime/query-exec-mgr.h M be/src/runtime/query-state.cc M be/src/runtime/query-state.h M be/src/runtime/runtime-state.cc M be/src/runtime/runtime-state.h M be/src/runtime/test-env.cc M be/src/runtime/test-env.h M be/src/runtime/tmp-file-mgr-test.cc M be/src/scheduling/admission-controller.cc M be/src/service/fe-support.cc M be/src/service/impala-http-handler.cc M be/src/service/query-exec-state.cc 25 files changed, 363 insertions(+), 351 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/30/5630/5 -- To view, visit http://gerrit.cloudera.org:8080/5630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id6b46652932b5638993623e98d1f0d60d8380ba0 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Marcel Kornacker