Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id EA54D200BFA for ; Thu, 12 Jan 2017 20:07:50 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E8CB9160B40; Thu, 12 Jan 2017 19:07:50 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3EA5D160B29 for ; Thu, 12 Jan 2017 20:07:50 +0100 (CET) Received: (qmail 50673 invoked by uid 500); 12 Jan 2017 19:07:49 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 50662 invoked by uid 99); 12 Jan 2017 19:07:49 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jan 2017 19:07:49 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D3B98180BA9 for ; Thu, 12 Jan 2017 19:07:48 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id D4YYP0cFDczp for ; Thu, 12 Jan 2017 19:07:48 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 731C95F299 for ; Thu, 12 Jan 2017 19:07:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0CJ7RuC006442; Thu, 12 Jan 2017 19:07:27 GMT Message-Id: <201701121907.v0CJ7RuC006442@ip-10-146-233-104.ec2.internal> Date: Thu, 12 Jan 2017 19:07:27 +0000 From: "Thomas Tauber-Marshall (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org Reply-To: tmarshall@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4748=3A_crash_in_TmpFileMgr_when_hitting_process_mem_limit=0A?= X-Gerrit-Change-Id: Ib0a624212bc17f7824e6d14ad143c0d5894206f8 X-Gerrit-ChangeURL: X-Gerrit-Commit: 2722bff870cc99c73bfe216c99ac87215faf1036 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 12 Jan 2017 19:07:51 -0000 Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4748: crash in TmpFileMgr when hitting process mem limit ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5683/2/be/src/runtime/tmp-file-mgr.h File be/src/runtime/tmp-file-mgr.h: Line 282: Status Write(DiskIoMgr* io_mgr, DiskIoRequestContext* io_ctx, File* file, Maybe briefly note pre/post conditions on write_in_flight_ here and for RetryWrite below. -- To view, visit http://gerrit.cloudera.org:8080/5683 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib0a624212bc17f7824e6d14ad143c0d5894206f8 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Thomas Tauber-Marshall Gerrit-HasComments: Yes