Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1AC6A200BFA for ; Thu, 12 Jan 2017 19:47:19 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1950C160B40; Thu, 12 Jan 2017 18:47:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6341F160B29 for ; Thu, 12 Jan 2017 19:47:18 +0100 (CET) Received: (qmail 8723 invoked by uid 500); 12 Jan 2017 18:47:17 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 8712 invoked by uid 99); 12 Jan 2017 18:47:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jan 2017 18:47:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id E8317C0C69 for ; Thu, 12 Jan 2017 18:47:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id fJmoFxUuyCyk for ; Thu, 12 Jan 2017 18:47:16 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 86BEC5FBE2 for ; Thu, 12 Jan 2017 18:47:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0CIlDhf005939; Thu, 12 Jan 2017 18:47:13 GMT Message-Id: <201701121847.v0CIlDhf005939@ip-10-146-233-104.ec2.internal> Date: Thu, 12 Jan 2017 18:47:13 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-2615=3A_warn_if_Status_is_ignored=0A?= X-Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc X-Gerrit-ChangeURL: X-Gerrit-Commit: 8bc7c1cbae9af25c38d7198fa0187758a75994c2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 12 Jan 2017 18:47:19 -0000 Tim Armstrong has posted comments on this change. Change subject: IMPALA-2615: warn if Status is ignored ...................................................................... Patch Set 7: Turns out there's a gcc bug that prevents this from working sometimes (including for DiskIoMgr::Init()). I updated the commit message to include this info. Shall we still go ahead even with this caveat? I think this is still worthwhile since clang will detect the problems/ -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: No