Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7B3F6200C08 for ; Thu, 12 Jan 2017 06:18:45 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 79C81160B4E; Thu, 12 Jan 2017 05:18:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C50EC160B50 for ; Thu, 12 Jan 2017 06:18:44 +0100 (CET) Received: (qmail 92543 invoked by uid 500); 12 Jan 2017 05:18:44 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 92532 invoked by uid 99); 12 Jan 2017 05:18:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jan 2017 05:18:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 52CACC0B2E for ; Thu, 12 Jan 2017 05:18:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id D19MKGINQymx for ; Thu, 12 Jan 2017 05:18:41 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 910205FAC3 for ; Thu, 12 Jan 2017 05:18:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0C5IY3k029902; Thu, 12 Jan 2017 05:18:34 GMT Message-Id: <201701120518.v0C5IY3k029902@ip-10-146-233-104.ec2.internal> Date: Thu, 12 Jan 2017 05:18:34 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Tim Armstrong Reply-To: henry@cloudera.com X-Gerrit-MessageType: merged Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4650=3A_Allow_protobuf_to_find_non-system_libraries_and_binaries=0A?= X-Gerrit-Change-Id: I942b3f18e25e2abc5aac167412b65abb680d3c5a X-Gerrit-ChangeURL: X-Gerrit-Commit: ed0aa66ee1ec3dd31f451ec70432bf58c6b682c4 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 12 Jan 2017 05:18:45 -0000 Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4650: Allow protobuf to find non-system libraries and binaries ...................................................................... IMPALA-4650: Allow protobuf to find non-system libraries and binaries This change makes PROTOBUF_GENERATE_CPP able to pick up Protobuf libraries and binaries that are found by CMake but not installed on the system LD_LIBRARY_PATH. Change-Id: I942b3f18e25e2abc5aac167412b65abb680d3c5a Reviewed-on: http://gerrit.cloudera.org:8080/5658 Tested-by: Impala Public Jenkins Reviewed-by: Henry Robinson --- M cmake_modules/FindProtobuf.cmake 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Impala Public Jenkins: Verified Henry Robinson: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/5658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I942b3f18e25e2abc5aac167412b65abb680d3c5a Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong