Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 9400F200C08 for ; Thu, 12 Jan 2017 01:53:42 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 929C7160B50; Thu, 12 Jan 2017 00:53:42 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DA806160B4E for ; Thu, 12 Jan 2017 01:53:41 +0100 (CET) Received: (qmail 992 invoked by uid 500); 12 Jan 2017 00:53:41 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 980 invoked by uid 99); 12 Jan 2017 00:53:40 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jan 2017 00:53:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5D914C0BB2 for ; Thu, 12 Jan 2017 00:53:40 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id RKeUVOl3ysWt for ; Thu, 12 Jan 2017 00:53:38 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id A1EB95F286 for ; Thu, 12 Jan 2017 00:53:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0C0rahH024429; Thu, 12 Jan 2017 00:53:36 GMT Message-Id: <201701120053.v0C0rahH024429@ip-10-146-233-104.ec2.internal> Date: Thu, 12 Jan 2017 00:53:36 +0000 From: "Matthew Jacobs (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil Reply-To: mj@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4747=3A_macros_should_only_evaluate_their_arguments_once=0A?= X-Gerrit-Change-Id: I1229849150d3f747e6780cc072ba063152ade1a9 X-Gerrit-ChangeURL: X-Gerrit-Commit: b36b25702234429fe3b9fe400b885720b020f455 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 12 Jan 2017 00:53:42 -0000 Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4747: macros should only evaluate their arguments once ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5686 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1229849150d3f747e6780cc072ba063152ade1a9 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Matthew Jacobs Gerrit-Reviewer: Sailesh Mukil Gerrit-HasComments: No