Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7CBFE200BFB for ; Wed, 11 Jan 2017 23:55:28 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 7B797160B4E; Wed, 11 Jan 2017 22:55:28 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C698F160B3B for ; Wed, 11 Jan 2017 23:55:27 +0100 (CET) Received: (qmail 59046 invoked by uid 500); 11 Jan 2017 22:55:27 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 59035 invoked by uid 99); 11 Jan 2017 22:55:26 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 11 Jan 2017 22:55:26 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 5D0C6C0FEC for ; Wed, 11 Jan 2017 22:55:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id l7UhSScutw-y for ; Wed, 11 Jan 2017 22:55:25 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 96C3F5F3F5 for ; Wed, 11 Jan 2017 22:55:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0BMtP2s019759; Wed, 11 Jan 2017 22:55:25 GMT Message-Id: <201701112255.v0BMtP2s019759@ip-10-146-233-104.ec2.internal> Date: Wed, 11 Jan 2017 22:55:25 +0000 From: "Lars Volker (Code Review)" To: Joe McDonnell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker Reply-To: lv@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4341=3A_Add_metadata_load_to_planner_timeline=0A?= X-Gerrit-Change-Id: I6f01a35e5f9f5007a0298acfc8e16da00ef99c6c X-Gerrit-ChangeURL: X-Gerrit-Commit: 47daa51f8f9ca2b84bd134429f9a86d5ab0d47cb In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 11 Jan 2017 22:55:28 -0000 Lars Volker has posted comments on this change. Change subject: IMPALA-4341: Add metadata load to planner timeline ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5685/1//COMMIT_MSG Commit Message: PS1, Line 13: metata typo PS1, Line 15: On successful analysis what happens on unsuccessful analysis? Doesn't it always have that reference? Line 20: - Analysis Requires Metadata Load: 42.972ms (42.972ms) nit: the other entries seem to start words with lowercase. http://gerrit.cloudera.org:8080/#/c/5685/1/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: Line 382: analysisResult_.timeline_ = timeline_; Move below the next if statement, which checks analyzer is set. -- To view, visit http://gerrit.cloudera.org:8080/5685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f01a35e5f9f5007a0298acfc8e16da00ef99c6c Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Joe McDonnell Gerrit-Reviewer: Lars Volker Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes