Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <201701110222.v0B2M8e5004978@ip-10-146-233-104.ec2.internal>
Date: Wed, 11 Jan 2017 02:22:08 +0000
From: "Taras Bobrovytsky (Code Review)" <gerrit@cloudera.org>
To: Michael Brown <mikeb@cloudera.com>, impala-cr@cloudera.com,
        reviews@impala.incubator.apache.org
CC: David Knupp <dknupp@cloudera.com>
Reply-To: tbobrovytsky@cloudera.com
Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4351=2CIMPALA-4353=3A_=5Bqgen=5D_randomly_generate_INSERT_statements=0A?=
In-Reply-To: <gerrit.1481596671000.I842b41f0eed07ab30ec76d8fc3cdd5affb525af6@gerrit.cloudera.org>
References: <gerrit.1481596671000.I842b41f0eed07ab30ec76d8fc3cdd5affb525af6@gerrit.cloudera.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.12.2
archived-at: Wed, 11 Jan 2017 02:22:13 -0000

Taras Bobrovytsky has posted comments on this change.

Change subject: IMPALA-4351,IMPALA-4353: [qgen] randomly generate INSERT statements
......................................................................


Patch Set 6: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5486/4/tests/comparison/model_translator.py
File tests/comparison/model_translator.py:

Line 799:     return data_type_class.__name__.upper()
> It's basically the same case as with Oracle: the code exists and maybe work
I never had a need to run against MySQL instead of PostgreSQL. I would vote to remove this code.

In general I would vote to remove code that is not being run regularly. Maybe keep it on some branch until we are ready to start running it regularly again.


http://gerrit.cloudera.org:8080/#/c/5486/4/tests/comparison/query_profile.py
File tests/comparison/query_profile.py:

PS4, Line 647: partial'
> Old habit related to C, when you could mistake = for == in comparison. If y
Yeah, makes sense. It's fine, don't change it.


-- 
To view, visit http://gerrit.cloudera.org:8080/5486
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I842b41f0eed07ab30ec76d8fc3cdd5affb525af6
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-Reviewer: Taras Bobrovytsky <tbobrovytsky@cloudera.com>
Gerrit-HasComments: Yes