Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 36CB1200BF4 for ; Fri, 6 Jan 2017 20:37:38 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 3551B160B39; Fri, 6 Jan 2017 19:37:38 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7D3BD160B37 for ; Fri, 6 Jan 2017 20:37:37 +0100 (CET) Received: (qmail 50573 invoked by uid 500); 6 Jan 2017 19:37:36 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 50561 invoked by uid 99); 6 Jan 2017 19:37:36 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jan 2017 19:37:36 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0F619C043B for ; Fri, 6 Jan 2017 19:37:36 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id HcO2hgtPrk1g for ; Fri, 6 Jan 2017 19:37:35 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 2C0A15F5C6 for ; Fri, 6 Jan 2017 19:37:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v06JbFrC001494; Fri, 6 Jan 2017 19:37:15 GMT Message-Id: <201701061937.v06JbFrC001494@ip-10-146-233-104.ec2.internal> Date: Fri, 6 Jan 2017 19:37:15 +0000 From: "Henry Robinson (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Sailesh Mukil , Tim Armstrong Reply-To: henry@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3882=3A_Simplify_some_query_exec_state_locking=0A?= X-Gerrit-Change-Id: I516357d2b5e9eb83e8209872cbe4c078c778a629 X-Gerrit-ChangeURL: X-Gerrit-Commit: 756c00a909a957bdc8aba98031c31d0d6ca87bc5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Fri, 06 Jan 2017 19:37:38 -0000 Henry Robinson has posted comments on this change. Change subject: IMPALA-3882: Simplify some query exec state locking ...................................................................... Patch Set 6: (1 comment) Abandoned this for now: Sailesh's comment lead me down a rat hole that I don't have time to address at the moment. We should pick this back up soon though, since the cascading locking can cause problems. http://gerrit.cloudera.org:8080/#/c/4935/6/be/src/service/impala-beeswax-server.cc File be/src/service/impala-beeswax-server.cc: Line 40: using namespace strings; > This shouldn't be needed, we have 'using strings::Substitute' in names.h no Done -- To view, visit http://gerrit.cloudera.org:8080/4935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I516357d2b5e9eb83e8209872cbe4c078c778a629 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Sailesh Mukil Gerrit-Reviewer: Tim Armstrong Gerrit-HasComments: Yes