Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 38115200BF3 for ; Thu, 5 Jan 2017 23:26:37 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 369EC160B33; Thu, 5 Jan 2017 22:26:37 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7F7BC160B26 for ; Thu, 5 Jan 2017 23:26:36 +0100 (CET) Received: (qmail 83507 invoked by uid 500); 5 Jan 2017 22:26:35 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 83492 invoked by uid 99); 5 Jan 2017 22:26:35 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2017 22:26:35 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0172CC0258 for ; Thu, 5 Jan 2017 22:26:35 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id DCIZg5MI4QzY for ; Thu, 5 Jan 2017 22:26:34 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 062005F252 for ; Thu, 5 Jan 2017 22:26:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v05MQVew017547; Thu, 5 Jan 2017 22:26:32 GMT Message-Id: <201701052226.v05MQVew017547@ip-10-146-233-104.ec2.internal> Date: Thu, 5 Jan 2017 22:26:31 +0000 From: "Jim Apple (Code Review)" To: Tim Armstrong , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Marcel Kornacker , Jim Apple Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-4707=3A_fix_use-after-free_in_QueryExecMgr=0A?= X-Gerrit-Change-Id: I329ff758a0de148a3bdfedc245e56c3a63255535 X-Gerrit-ChangeURL: X-Gerrit-Commit: cca7289f9e2efba1438fe236b2b65bb5e0507235 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 05 Jan 2017 22:26:37 -0000 Jim Apple has posted comments on this change. Change subject: IMPALA-4707: fix use-after-free in QueryExecMgr ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5615/1/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: Line 141 AtomicInt::Add says it returns the new value. If the new value was greater than 0, wouldn't the refcount have been greater than 0, making qs still live? -- To view, visit http://gerrit.cloudera.org:8080/5615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I329ff758a0de148a3bdfedc245e56c3a63255535 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: Marcel Kornacker Gerrit-HasComments: Yes