Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 01848200BF3 for ; Thu, 5 Jan 2017 19:01:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id F4081160B33; Thu, 5 Jan 2017 18:01:53 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4C44E160B26 for ; Thu, 5 Jan 2017 19:01:53 +0100 (CET) Received: (qmail 56149 invoked by uid 500); 5 Jan 2017 18:01:52 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 56138 invoked by uid 99); 5 Jan 2017 18:01:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jan 2017 18:01:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D86EEC66A4 for ; Thu, 5 Jan 2017 18:01:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id bEhu8gAAZnnJ for ; Thu, 5 Jan 2017 18:01:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 142E95F286 for ; Thu, 5 Jan 2017 18:01:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v05I1kTC008770; Thu, 5 Jan 2017 18:01:46 GMT Message-Id: <201701051801.v05I1kTC008770@ip-10-146-233-104.ec2.internal> Date: Thu, 5 Jan 2017 18:01:46 +0000 From: "Henry Robinson (Code Review)" To: Greg Rahn , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Lars Volker Reply-To: henry@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Add_thousands_separator_to_cardinality_in_plan_diagram=0A?= X-Gerrit-Change-Id: I23bfbd8d235c7f1ab7a22d640e557d8ae9a00947 X-Gerrit-ChangeURL: X-Gerrit-Commit: 4112b230595edc29cd2ecf55a051b782ab052f34 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Thu, 05 Jan 2017 18:01:54 -0000 Henry Robinson has uploaded a new patch set (#4). Change subject: Add thousands separator to cardinality in plan diagram ...................................................................... Add thousands separator to cardinality in plan diagram Tested manually by visually validating the cardinality numbers have thousands separators. Change-Id: I23bfbd8d235c7f1ab7a22d640e557d8ae9a00947 --- M www/query_plan.tmpl 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/5587/4 -- To view, visit http://gerrit.cloudera.org:8080/5587 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I23bfbd8d235c7f1ab7a22d640e557d8ae9a00947 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Greg Rahn Gerrit-Reviewer: Henry Robinson Gerrit-Reviewer: Lars Volker