Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D7015200BEF for ; Wed, 4 Jan 2017 22:24:56 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id D653E160B3A; Wed, 4 Jan 2017 21:24:56 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2CD18160B21 for ; Wed, 4 Jan 2017 22:24:56 +0100 (CET) Received: (qmail 35722 invoked by uid 500); 4 Jan 2017 21:24:55 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 35711 invoked by uid 99); 4 Jan 2017 21:24:55 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2017 21:24:55 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id C1E10C002D for ; Wed, 4 Jan 2017 21:24:54 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id v_14gXdeB2hz for ; Wed, 4 Jan 2017 21:24:54 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id C23A55F644 for ; Wed, 4 Jan 2017 21:24:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v04LOpfB024417; Wed, 4 Jan 2017 21:24:51 GMT Message-Id: <201701042124.v04LOpfB024417@ip-10-146-233-104.ec2.internal> Date: Wed, 4 Jan 2017 21:24:51 +0000 From: "Tim Armstrong (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Dan Hecht Reply-To: tarmstrong@cloudera.com X-Gerrit-MessageType: newpatchset Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_IMPALA-3202=3A_variable-length_scratch_file_ranges=0A?= X-Gerrit-Change-Id: Ic0ad84493c2c93a5602c404a83c718f25ea25575 X-Gerrit-ChangeURL: X-Gerrit-Commit: 78d21a11cd0c3250ba2e95e549a5243731f15425 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 04 Jan 2017 21:24:57 -0000 Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-3202: variable-length scratch file ranges ...................................................................... IMPALA-3202: variable-length scratch file ranges This uses a simple approach where scratch ranges are managed in power-of-two size classes and we don't attempt to coalesce or split the ranges to move them into different size classes. Thus this does not optimally reuse space if a query spills a variety of page sizes, but improving this may not be worth the added complexity. Testing: Extended tmp-file-mgr-test to exercise the variable scratch range support. We will get system test coverage once this is used by the new buffer pool. Change-Id: Ic0ad84493c2c93a5602c404a83c718f25ea25575 --- M be/src/runtime/buffered-block-mgr.cc M be/src/runtime/tmp-file-mgr-test.cc M be/src/runtime/tmp-file-mgr.cc M be/src/runtime/tmp-file-mgr.h 4 files changed, 95 insertions(+), 94 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/5597/4 -- To view, visit http://gerrit.cloudera.org:8080/5597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ic0ad84493c2c93a5602c404a83c718f25ea25575 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong Gerrit-Reviewer: Dan Hecht