Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CB35C200BEF for ; Wed, 4 Jan 2017 21:47:06 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id CAC57160B3A; Wed, 4 Jan 2017 20:47:06 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E3C6C160B21 for ; Wed, 4 Jan 2017 21:47:05 +0100 (CET) Received: (qmail 20417 invoked by uid 500); 4 Jan 2017 20:47:05 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 20406 invoked by uid 99); 4 Jan 2017 20:47:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2017 20:47:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 7DFAA1804AE for ; Wed, 4 Jan 2017 20:47:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.362 X-Spam-Level: X-Spam-Status: No, score=0.362 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Nk2gMe6aP-Q1 for ; Wed, 4 Jan 2017 20:47:02 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 612D05FDE7 for ; Wed, 4 Jan 2017 20:47:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v04Kkv88024004; Wed, 4 Jan 2017 20:46:57 GMT Message-Id: <201701042046.v04Kkv88024004@ip-10-146-233-104.ec2.internal> Date: Wed, 4 Jan 2017 20:46:57 +0000 From: "Jim Apple (Code Review)" To: John Russell , impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , Ambreen Kazi Reply-To: jbapple-impala@apache.org X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Remove_audience==22Cloudera=22_from_DITAVal=2C_replace_with_audience==22hidden=22=2E=0A?= X-Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72 X-Gerrit-ChangeURL: X-Gerrit-Commit: ed38791451670ee0939c4ad281fbc19c036da8a5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 04 Jan 2017 20:47:07 -0000 Jim Apple has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5591/1//COMMIT_MSG Commit Message: PS1, Line 7: Remove audience="Cloudera" from DITAVal > I tried to amend the commit message when squashing but must have done it wr The steps I use for squashing are: 1. Make the second commit. 2. git rebase -i HEAD~1 3. Mark the first commit reword and the second commit fixup 4. Change the commit message (leaving Change-Id alone) 5. git push to gerrit. -- To view, visit http://gerrit.cloudera.org:8080/5591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Anonymous Coward #250 Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-HasComments: Yes