Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 975E0200C00 for ; Wed, 4 Jan 2017 01:06:54 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 95EF0160B46; Wed, 4 Jan 2017 00:06:54 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DF615160B43 for ; Wed, 4 Jan 2017 01:06:53 +0100 (CET) Received: (qmail 43198 invoked by uid 500); 4 Jan 2017 00:06:53 -0000 Mailing-List: contact reviews-help@impala.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list reviews@impala.incubator.apache.org Received: (qmail 43131 invoked by uid 99); 4 Jan 2017 00:06:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jan 2017 00:06:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 4CDBAC228B for ; Wed, 4 Jan 2017 00:06:52 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.363 X-Spam-Level: X-Spam-Status: No, score=0.363 tagged_above=-999 required=6.31 tests=[RDNS_DYNAMIC=0.363, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id Ls9sia6hGuxC for ; Wed, 4 Jan 2017 00:06:51 +0000 (UTC) Received: from ip-10-146-233-104.ec2.internal (ec2-75-101-130-251.compute-1.amazonaws.com [75.101.130.251]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 8A3035F486 for ; Wed, 4 Jan 2017 00:06:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by ip-10-146-233-104.ec2.internal (8.14.4/8.14.4) with ESMTP id v0406op9013987; Wed, 4 Jan 2017 00:06:51 GMT Message-Id: <201701040006.v0406op9013987@ip-10-146-233-104.ec2.internal> Date: Wed, 4 Jan 2017 00:06:50 +0000 From: "John Russell (Code Review)" To: impala-cr@cloudera.com, reviews@impala.incubator.apache.org CC: Jim Apple , Ambreen Kazi Reply-To: jrussell@cloudera.com X-Gerrit-MessageType: comment Subject: =?UTF-8?Q?=5BImpala-ASF-CR=5D_Remove_audience==22Cloudera=22_from_DITAVal=2C_replace_with_audience==22hidden=22=2E=0A?= X-Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72 X-Gerrit-ChangeURL: X-Gerrit-Commit: ed38791451670ee0939c4ad281fbc19c036da8a5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.12.2 archived-at: Wed, 04 Jan 2017 00:06:54 -0000 John Russell has posted comments on this change. Change subject: Remove audience="Cloudera" from DITAVal, replace with audience="hidden". ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5591/1//COMMIT_MSG Commit Message: PS1, Line 7: Remove audience="Cloudera" from DITAVal I tried to amend the commit message when squashing but must have done it wrong. I didn't actually remove audience="Cloudera" yet because that would have caused a build error. I plan to get rid of audience="Cloudera" in 3 stages each with its own gerrit review - add the capability for audience="hidden", global search/replace of audience="Cloudera" -> audience="hidden", and finally remove the possibility of having audience="Cloudera". http://gerrit.cloudera.org:8080/#/c/5591/1/docs/impala_html.ditaval File docs/impala_html.ditaval: Line 21: (obsolete or abandoned), or aspirational (maybe write new topic somewhere down the road). > long line. I have an XML formatter tool that will apply some line length constraints, but because that will cause such a large-scale diff across so many files I prefer to address line length globally in a later gerrit review. -- To view, visit http://gerrit.cloudera.org:8080/5591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0771ccf912d8112194ad52a7fa76b092ea6cff72 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: John Russell Gerrit-Reviewer: Ambreen Kazi Gerrit-Reviewer: Anonymous Coward #250 Gerrit-Reviewer: Jim Apple Gerrit-Reviewer: John Russell Gerrit-HasComments: Yes