impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Behm (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Improvements to "Unknown disk-ID" warning
Date Tue, 31 Jan 2017 23:52:19 GMT
Alex Behm has posted comments on this change.

Change subject: Improvements to "Unknown disk-ID" warning
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5828/1//COMMIT_MSG
Commit Message:

Line 7: Improvements to "Unknown disk-ID" warning
IMPALA-1427?


Line 9: This commit,
This patch seems fine. 

Another idea to consider:
I'm not really sure how useful it is to return these missing disk id warnings from scans.
An alternative might be to report the number of missing disk ids in the explain plan of a
query and throw away this runtime checking and warning through the existing path.


-- 
To view, visit http://gerrit.cloudera.org:8080/5828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iddb132ff7ad66f3291b93bf9d8061bd0525ef1b2
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Bharath Vissapragada <bharathv@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.behm@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message