impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add .pep8rc for Impala's Python style
Date Tue, 31 Jan 2017 18:38:34 GMT
Jim Apple has posted comments on this change.

Change subject: Add .pep8rc for Impala's Python style
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc
File .pep8rc:

PS1, Line 5: # E251 - Remove whitespace around parameter '=' sign.
           : # E301 - Add missing blank line.
> Yes, that was my intention, too. Such a tool sounds very useful. Is it in a
https://github.com/jbapple-cloudera/clang-format-infer

It uses hill-climbing with random restarts to search the state space.

The config is pretty brittle, I must admit, but I think that's mainly a clang problem, so
you might be able to repurpose it.


-- 
To view, visit http://gerrit.cloudera.org:8080/5829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65a99fc6e364eb1e49e21d0ba97546bc25f65a27
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message