impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Volker (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add .pep8rc for Impala's Python style
Date Tue, 31 Jan 2017 18:26:01 GMT
Lars Volker has posted comments on this change.

Change subject: Add .pep8rc for Impala's Python style
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc
File .pep8rc:

PS1, Line 2: # E101 - Reindent all lines.
> I moderately disagree with this being ignored. Can you talk about your reas
Without E101 and E111, autopep8 will re-indent the whole file to use 4 spaces instead of 2,
and I couldn't find a way around this.

https://github.com/hhatto/autopep8/blob/master/autopep8.py#L3095


PS1, Line 5: # E251 - Remove whitespace around parameter '=' sign.
           : # E301 - Add missing blank line.
> I strongly disagree with these being ignored. Can you talk about your reaso
I tried to make this match the style that I found, but I don't feel strongly about it and
would be glad if we could get as close to PEP8 as possible. I'll comment more on this on dev@.


http://gerrit.cloudera.org:8080/#/c/5829/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Add .pep8rc for Impala's Python style
> What tools get affected by the presence of this? Can it stay in the top-lev
No tools are automatically affected by this, but several can use it if pointed to it with
a command line flag. Should we point this out here or would the wiki page be sufficient?


-- 
To view, visit http://gerrit.cloudera.org:8080/5829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65a99fc6e364eb1e49e21d0ba97546bc25f65a27
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message