impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Apple (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Add .pep8rc for Impala's Python style
Date Tue, 31 Jan 2017 16:38:16 GMT
Jim Apple has posted comments on this change.

Change subject: Add .pep8rc for Impala's Python style
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5829/1/.pep8rc
File .pep8rc:

PS1, Line 5: # E251 - Remove whitespace around parameter '=' sign.
           : # E301 - Add missing blank line.
> I strongly disagree with these being ignored. Can you talk about your reaso
I can't speak for Lars, but I worked on our initial .clang-format, and I tried to make it
match our existing style as closely as possible. I even wrote a little tool to explore the
state space of config options and find the ones that match our codebase with as small a diff
as possible. As a result of this matching, the options are a bit odd, but it will hopefully
encourage new code to match the old style as closely as possible, which might be easier to
read than having new code be in the accepted pep8 style and old code in the idiosyncratic
Impala style.


-- 
To view, visit http://gerrit.cloudera.org:8080/5829
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I65a99fc6e364eb1e49e21d0ba97546bc25f65a27
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message