impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Laurel Hale (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] Patch references to Cloudera and CDH in Impala tutorial
Date Mon, 30 Jan 2017 21:20:49 GMT
Laurel Hale has posted comments on this change.

Change subject: Patch references to Cloudera and CDH in Impala tutorial
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

The use of keyref to change "CDH" to a Hadoop distribution number didn't seem to work (see
line 60) and use of parentheses not necessary in line 1700.

http://gerrit.cloudera.org:8080/#/c/5663/1/docs/topics/impala_tutorial.xml
File docs/topics/impala_tutorial.xml:

Line 60:         If you already have a <keyword keyref="hadoop_distro"/> environment
set up and just need to add Impala to it, follow the installation
This doesn't seem to work. It's showing up as "CDH" in the build.


PS1, Line 1700: (Currently, this technique only works for Parquet files.)
Parentheses not necessary.


-- 
To view, visit http://gerrit.cloudera.org:8080/5663
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44245b65ce6f247ae8771f582f4b33c3712145ae
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jrussell@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Laurel Hale <laurel@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message