impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Brown (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-4818: Ensure the same number of tests are run every time
Date Mon, 30 Jan 2017 16:43:36 GMT
Michael Brown has posted comments on this change.

Change subject: IMPALA-4818: Ensure the same number of tests are run every time
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5784/2/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:

PS2, Line 195:     if cls.exploration_strategy() != 'exhaustive':
             :       cls.ImpalaTestMatrix.add_constraint(lambda v: v.get_value('cancel_delay')
in [3])
L196 will rarely if ever get executed, because the workload as derived from L60 is "tpch",
not "functional-query". Typical exhaustive tests tend only to apply to tests whose workload
is functional-query, via "--workload_exploration_strategy functional-query:exhaustive".

I believe this is so because, unlike the functional database, the tpch database will not exist
in all the typical exhaustive formats when doing a data load, which means typical "exhaustive
vectors" aren't possible with tpch. However, the queries (L35) here come from tpch, hence
the value of get_workload().

Some options:

- Remove L195. If tests are quick, this is OK.
or
- Hack up test dimensions and workload to avoid redundant tests but also truly run various
cancel delays when workload_exploration_strategy is functional-query:exhaustive .
or
- Remove L195-196 if loss of coverage is only negligible


-- 
To view, visit http://gerrit.cloudera.org:8080/5784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22cecfbe7c9a102f788d01eb80aa188579ef6d7e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: David Knupp <dknupp@cloudera.com>
Gerrit-Reviewer: Jim Apple <jbapple-impala@apache.org>
Gerrit-Reviewer: Michael Brown <mikeb@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message