impala-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Hecht (Code Review)" <ger...@cloudera.org>
Subject [Impala-ASF-CR] IMPALA-3785: Record query handle for invalid handle
Date Mon, 30 Jan 2017 04:56:20 GMT
Dan Hecht has posted comments on this change.

Change subject: IMPALA-3785: Record query handle for invalid handle
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/5748/4/be/src/service/impala-beeswax-server.cc
File be/src/service/impala-beeswax-server.cc:

PS4, Line 193: handle.id
how about PrintId(query_id) for consistency with the other cases? this path isn't perf critical
at all.


PS4, Line 253: handle.id
same


http://gerrit.cloudera.org:8080/#/c/5748/4/be/src/util/debug-util-test.cc
File be/src/util/debug-util-test.cc:

Line 81: TEST(DebugUtil, ErrMsgBenchmark) {
Henry mentioned in the previous patchset where benchmarking code usually lives.


http://gerrit.cloudera.org:8080/#/c/5748/4/tests/hs2/test_hs2.py
File tests/hs2/test_hs2.py:

PS4, Line 234: 0123456789abcdef
how about writing these as as hex bytes so that it's obvious that the query id printed below
matches exactly? i.e. "\x01\x23\x45 ..."


-- 
To view, visit http://gerrit.cloudera.org:8080/5748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc113b3673e1b90f81e80e841740b8006bfd31ba
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Zach Amsden <zamsden@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhecht@cloudera.com>
Gerrit-Reviewer: Henry Robinson <henry@cloudera.com>
Gerrit-Reviewer: Zach Amsden <zamsden@cloudera.com>
Gerrit-HasComments: Yes

Mime
View raw message